mcvsubbu commented on a change in pull request #4764: Fix the bug of releasing
the segment when there are still threads working on it
URL: https://github.com/apache/incubator-pinot/pull/4764#discussion_r341395417
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/CombineGroupByOperator.java
##########
@@ -224,6 +241,8 @@ public void runJob() {
future.cancel(true);
}
}
+ // Deregister the main thread and wait for all threads done
Review comment:
OK, I see that the phaser. awaitAdvance() should cover this case. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
