mcvsubbu commented on a change in pull request #4764: Fix the bug of releasing the segment when there are still threads working on it URL: https://github.com/apache/incubator-pinot/pull/4764#discussion_r341399092
########## File path: pinot-core/src/test/java/org/apache/pinot/core/operator/CombineSlowOperatorsTest.java ########## @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator; + +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.TimeoutException; +import java.util.concurrent.atomic.AtomicBoolean; +import org.apache.pinot.common.response.ProcessingException; +import org.apache.pinot.core.common.Block; +import org.apache.pinot.core.common.Operator; +import org.apache.pinot.core.operator.blocks.IntermediateResultsBlock; +import org.apache.pinot.core.plan.maker.InstancePlanMakerImplV2; +import org.apache.pinot.pql.parsers.Pql2Compiler; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + +import static org.testng.Assert.assertEquals; +import static org.testng.Assert.assertFalse; +import static org.testng.Assert.assertNotNull; +import static org.testng.Assert.assertTrue; + + +/** + * This test mimic the behavior of combining slow operators, where operation is not done by the timeout. When the + * combine operator returns, test whether the slow operators are properly interrupted, and if all the slow operators are + * not running in order to safely release the segment references. + */ +public class CombineSlowOperatorsTest { + private static final int NUM_OPERATORS = 10; + private static final int NUM_THREADS = 2; + private static final long TIMEOUT_MS = 100L; + private static final Pql2Compiler COMPILER = new Pql2Compiler(); + + private ExecutorService _executorService; + + @BeforeClass + public void setUp() { + _executorService = Executors.newFixedThreadPool(NUM_THREADS); + } + + @Test + public void testCombineOperator() { + List<Operator> operators = getOperators(); + CombineOperator combineOperator = new CombineOperator(operators, _executorService, TIMEOUT_MS, + COMPILER.compileToBrokerRequest("SELECT * FROM table")); + testCombineOperator(operators, combineOperator); + } + + @Test + public void testCombineGroupByOperator() { + List<Operator> operators = getOperators(); + CombineGroupByOperator combineGroupByOperator = new CombineGroupByOperator(operators, + COMPILER.compileToBrokerRequest("SELECT COUNT(*) FROM table GROUP BY column"), _executorService, TIMEOUT_MS, + InstancePlanMakerImplV2.DEFAULT_NUM_GROUPS_LIMIT); + testCombineOperator(operators, combineGroupByOperator); + } + + @Test + public void testCombineGroupByOrderByOperator() { + List<Operator> operators = getOperators(); + CombineGroupByOrderByOperator combineGroupByOrderByOperator = new CombineGroupByOrderByOperator(operators, + COMPILER.compileToBrokerRequest("SELECT COUNT(*) FROM table GROUP BY column"), _executorService, TIMEOUT_MS); + testCombineOperator(operators, combineGroupByOrderByOperator); + } + + public void testCombineOperator(List<Operator> operators, BaseOperator combineOperator) { + IntermediateResultsBlock intermediateResultsBlock = (IntermediateResultsBlock) combineOperator.nextBlock(); + List<ProcessingException> processingExceptions = intermediateResultsBlock.getProcessingExceptions(); + assertNotNull(processingExceptions); + assertEquals(processingExceptions.size(), 1); + assertTrue(processingExceptions.get(0).getMessage().contains(TimeoutException.class.getName())); + + // When the CombineOperator returns, all operators should be either not scheduled or interrupted, and no operator + // should be running so that the segment references can be safely released + for (Operator operator : operators) { + SlowOperator slowOperator = (SlowOperator) operator; + assertFalse(slowOperator._operationInProgress.get()); + assertFalse(slowOperator._notInterrupted.get()); + } + } + + @AfterClass + public void tearDown() { + _executorService.shutdown(); + } + + private List<Operator> getOperators() { + List<Operator> operators = new ArrayList<>(NUM_OPERATORS); + for (int i = 0; i < NUM_OPERATORS; i++) { + operators.add(new SlowOperator()); + } + return operators; + } + + private static class SlowOperator extends BaseOperator { + final AtomicBoolean _operationInProgress = new AtomicBoolean(); + final AtomicBoolean _notInterrupted = new AtomicBoolean(); + + @Override + protected Block getNextBlock() { + _operationInProgress.set(true); + try { + Thread.sleep(3_600_000L); + } catch (InterruptedException e) { + // Thread should be interrupted + throw new RuntimeException(e); + } finally { + // Wait for 100 milliseconds before marking the operation done + try { + Thread.sleep(100L); + } catch (InterruptedException e) { + // Ignore Review comment: we should not see interrupted exception here, right? We have already fielded the exception and marked it as a Runtime Exception like all operators will do in production. OK, perhaps if the test is killed, we can get one? Good to add that as a comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
