Jackie-Jiang commented on a change in pull request #4798: Decouple Key from
Record
URL: https://github.com/apache/incubator-pinot/pull/4798#discussion_r343406507
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/IndexedTable.java
##########
@@ -18,75 +18,55 @@
*/
package org.apache.pinot.core.data.table;
-import java.util.Iterator;
+import java.util.Arrays;
import java.util.List;
-import org.apache.commons.collections.CollectionUtils;
import org.apache.pinot.common.request.AggregationInfo;
import org.apache.pinot.common.request.SelectionSort;
import org.apache.pinot.common.utils.DataSchema;
-import org.apache.pinot.core.query.aggregation.function.AggregationFunction;
-import
org.apache.pinot.core.query.aggregation.function.AggregationFunctionUtils;
/**
- * Base abstract implementation of Table for indexed lookup
+ * Base implementation of Map-based Table for indexed lookup
*/
-public abstract class IndexedTable implements Table {
+public abstract class IndexedTable extends BaseTable {
- AggregationFunction[] _aggregationFunctions;
- int _numAggregations;
- private DataSchema _dataSchema;
-
- // the capacity we need to trim to
- int _capacity;
- // the capacity with added buffer, in order to collect more records than
capacity for better precision
- int _maxCapacity;
-
- boolean _isOrderBy;
- IndexedTableResizer _indexedTableResizer;
+ private KeyExtractor _keyExtractor;
Review comment:
final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
