Jackie-Jiang commented on a change in pull request #4798: Decouple Key from
Record
URL: https://github.com/apache/incubator-pinot/pull/4798#discussion_r343406090
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/Record.java
##########
@@ -22,33 +22,24 @@
/**
- * Defines a single record in Pinot comprising of keys and values
+ * Defines a single record in Pinot
*/
public class Record {
- private Key _key;
- private Object[] _values;
+ private Object[] _columns;
Review comment:
Recommend renaming this to `_values`, `_columns` sounds like column names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
