codecov-io edited a comment on issue #4774: Refactor virtualColumn URL: https://github.com/apache/incubator-pinot/pull/4774#issuecomment-548993487 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=h1) Report > Merging [#4774](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/343aadb28058ea4fbb38ef17887f0ce19ef8c5be?src=pr&el=desc) will **decrease** coverage by `0.1%`. > The diff coverage is `83.78%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4774 +/- ## =========================================== - Coverage 57.7% 57.6% -0.11% Complexity 4 4 =========================================== Files 1211 1209 -2 Lines 65572 65570 -2 Branches 9560 9561 +1 =========================================== - Hits 37841 37774 -67 - Misses 24854 24924 +70 + Partials 2877 2872 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ment/virtualcolumn/DocIdVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vRG9jSWRWaXJ0dWFsQ29sdW1uUHJvdmlkZXIuamF2YQ==) | `74.35% <100%> (+1.85%)` | `0 <0> (ø)` | :arrow_down: | | [...indexsegment/immutable/ImmutableSegmentLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRMb2FkZXIuamF2YQ==) | `91.83% <100%> (-0.33%)` | `0 <0> (ø)` | | | [...gment/virtualcolumn/BaseVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vQmFzZVZpcnR1YWxDb2x1bW5Qcm92aWRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rtualcolumn/SingleStringVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vU2luZ2xlU3RyaW5nVmlydHVhbENvbHVtblByb3ZpZGVyLmphdmE=) | `54.28% <100%> (+2.85%)` | `0 <0> (ø)` | :arrow_down: | | [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `44.61% <100%> (-1.54%)` | `0 <0> (ø)` | | | [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `83.43% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...re/segment/virtualcolumn/VirtualColumnContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtbkNvbnRleHQuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/pinot/common/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `32.07% <50%> (-0.62%)` | `0 <0> (ø)` | | | [...nt/virtualcolumn/VirtualColumnProviderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtblByb3ZpZGVyRmFjdG9yeS5qYXZh) | `56.25% <61.53%> (-16.48%)` | `0 <0> (ø)` | | | ... and [38 more](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=footer). Last update [343aadb...72aa312](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
