codecov-io edited a comment on issue #4774: Refactor virtualColumn URL: https://github.com/apache/incubator-pinot/pull/4774#issuecomment-548993487 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=h1) Report > Merging [#4774](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1cc296bbe5df7466e9510384949e842b09b9cd9a?src=pr&el=desc) will **increase** coverage by `20.55%`. > The diff coverage is `96.42%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4774 +/- ## ============================================= + Coverage 37.06% 57.61% +20.55% - Complexity 0 4 +4 ============================================= Files 1197 1196 -1 Lines 64981 64976 -5 Branches 9457 9457 ============================================= + Hits 24084 37437 +13353 + Misses 38705 24765 -13940 - Partials 2192 2774 +582 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ment/virtualcolumn/DocIdVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vRG9jSWRWaXJ0dWFsQ29sdW1uUHJvdmlkZXIuamF2YQ==) | `51.28% <100%> (+8.78%)` | `0 <0> (ø)` | :arrow_down: | | [...indexsegment/immutable/ImmutableSegmentLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRMb2FkZXIuamF2YQ==) | `92.15% <100%> (+1.96%)` | `0 <0> (ø)` | :arrow_down: | | [...gment/virtualcolumn/BaseVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vQmFzZVZpcnR1YWxDb2x1bW5Qcm92aWRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ultNullValueSingleStringVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vRGVmYXVsdE51bGxWYWx1ZVNpbmdsZVN0cmluZ1ZpcnR1YWxDb2x1bW5Qcm92aWRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...rtualcolumn/SingleStringVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vU2luZ2xlU3RyaW5nVmlydHVhbENvbHVtblByb3ZpZGVyLmphdmE=) | `50% <100%> (+1.42%)` | `0 <0> (ø)` | :arrow_down: | | [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `44.61% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `83.38% <100%> (+18.92%)` | `0 <0> (ø)` | :arrow_down: | | [...re/segment/virtualcolumn/VirtualColumnContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtbkNvbnRleHQuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/pinot/common/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `100% <100%> (+27.27%)` | `0 <0> (ø)` | :arrow_down: | | [...nt/virtualcolumn/VirtualColumnProviderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtblByb3ZpZGVyRmFjdG9yeS5qYXZh) | `72.72% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | ... and [599 more](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=footer). Last update [1cc296b...6987e23](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
