jadami10 commented on code in PR #18430:
URL: https://github.com/apache/pinot/pull/18430#discussion_r3197655342
##########
pinot-broker/src/main/java/org/apache/pinot/broker/querylog/QueryLogger.java:
##########
@@ -48,10 +48,29 @@ public class QueryLogger {
private static final Logger LOGGER =
LoggerFactory.getLogger(QueryLogger.class);
private static final QueryLogEntry[] QUERY_LOG_ENTRY_VALUES =
QueryLogEntry.values();
+ private static final String FINGERPRINT_FAILED_QUERY_REDACTED =
"FINGERPRINT_FAILED_QUERY_REDACTED";
+ private static final String FULLY_REDACTED = "REDACTED";
+
+ public enum SqlRedactionMode {
+ NONE,
+ LITERAL_VALUES,
+ FULL;
+
+ public static SqlRedactionMode fromString(String value) {
+ try {
+ return valueOf(value.toUpperCase());
+ } catch (IllegalArgumentException e) {
+ LOGGER.warn("Invalid SQL redaction mode '{}', defaulting to NONE",
value);
+ return NONE;
Review Comment:
ya, really good point. I've updated this for now while I think about your
other comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
