jadami10 commented on code in PR #18430:
URL: https://github.com/apache/pinot/pull/18430#discussion_r3197751854
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -332,6 +338,8 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
}
}
Review Comment:
another great catch. From what I initially found, the queries are all being
logged from `BaseSingleStageBrokerRequestHandler` and
`MultiStageBrokerRequestHandler`. My thinking is to start by exposing
`redactQuery` as a method on `QueryLogger` and have both classes use that. This
minimizes the amount of changes and doesn't require a global redaction config
that all classes need access to right. It does leave things open to this
pattern if needed in the future.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
