tarun11Mavani commented on code in PR #18368: URL: https://github.com/apache/pinot/pull/18368#discussion_r3200147518
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ColumnarMapIndexReader.java: ########## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.spi.index.reader; + +import java.util.Map; +import java.util.Set; +import javax.annotation.Nullable; +import org.apache.pinot.segment.spi.index.IndexReader; +import org.apache.pinot.spi.data.FieldSpec.DataType; +import org.roaringbitmap.buffer.ImmutableRoaringBitmap; + + +/** + * Reader for the COLUMNAR_MAP index. Each indexed key is materialized as its own per-key + * forward index plus a presence bitmap. + * + * <p>Implementations must be safe for concurrent reads. Mutable implementations may impose + * a single-writer constraint; refer to the concrete implementation's Javadoc for details. + * + * <p>Per-key {@code DataSource} construction is the responsibility of the surrounding + * {@code ColumnarMapDataSource} wrappers, not this reader. This interface exposes only + * the primitives a wrapper needs (key set, type, presence bitmap, per-doc map view). + */ +public interface ColumnarMapIndexReader extends IndexReader { + + /** Returns the set of all indexed key names. Never null; empty if no keys are indexed. */ + Set<String> getKeys(); + + /** Returns the value DataType for the given key, or null if the key is not indexed. */ + @Nullable + DataType getKeyValueType(String key); Review Comment: updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
