tarun11Mavani commented on code in PR #18368:
URL: https://github.com/apache/pinot/pull/18368#discussion_r3231589223
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/StandardIndexes.java:
##########
@@ -79,6 +82,7 @@ public class StandardIndexes {
public static final String TEXT_ID = "text_index";
public static final String H3_ID = "h3_index";
public static final String VECTOR_ID = "vector_index";
+ public static final String COLUMNAR_MAP_ID = "columnar_map";
Review Comment:
is this for renaming just the user-facing IndexType enum + config
sufficient, or do we want internal class name changes too?
i.e
Keep internal class names as ColumnarMap* (ColumnarMapIndexReader,
ColumnarMapDataSource, etc.) but rename user-facing surfaces:
IndexType.COLUMNAR_MAP → MAP, StandardIndexes.columnarMap() → map(),
COLUMNAR_MAP_INDEX_* property prefixes → MAP_INDEX_*.
Internal naming stays 'columnar' to avoid collision with existing
MapIndexReader/MapDataSource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
