npawar commented on a change in pull request #4798: Decouple Key from Record
URL: https://github.com/apache/incubator-pinot/pull/4798#discussion_r343814020
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/TableResizer.java
##########
@@ -112,12 +112,12 @@
* For aggregation values in the order by, the final result is extracted if
the intermediate result is non-comparable
*/
@VisibleForTesting
- IntermediateRecord getIntermediateRecord(Record record) {
+ IntermediateRecord getIntermediateRecord(Key key, Record record) {
Review comment:
while doing the resize, the Record gets converted to IntermediateRecord.
IntermediateRecord contains only the columns necessary for order by. It helps
prevent array index lookup during order by.
Now that we have gotten rid of Key from Record, we might be able to do this
using just the Record. Can revisit it after this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
