npawar commented on a change in pull request #4798: Decouple Key from Record
URL: https://github.com/apache/incubator-pinot/pull/4798#discussion_r343815287
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/TableResizer.java
##########
@@ -39,13 +39,13 @@
/**
* Helper class for trimming and sorting records in the IndexedTable, based on
the order by information
*/
-class IndexedTableResizer {
+class TableResizer {
Review comment:
In this PR, the changes are simply renaming IndexTableResizer to
TableResizer.
Pulling out the resize logic to a separate class was done previously. It
actually helped in being able to reuse the same logic for both of the
IndexedTable implementations. This same class will be used by the Table
implementation for distinct. As of now I don't see why it will become harder to
optimize. What were you thinking of in particular?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
