mcvsubbu commented on a change in pull request #4795: Enhance RoutingTable to
use ServerInstance
URL: https://github.com/apache/incubator-pinot/pull/4795#discussion_r343812462
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -261,8 +262,8 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
// Calculate routing table for the query
long routingStartTimeNs = System.nanoTime();
- Map<String, List<String>> offlineRoutingTable = null;
- Map<String, List<String>> realtimeRoutingTable = null;
+ Map<ServerInstance, List<String>> offlineRoutingTable = null;
Review comment:
IIRC this used to be a map of ServerInstance to segments, and we changed it
to be String to segments. Not sure what prompted the change. Perhaps
@Jackie-Jiang may recall (memory usage?) DNS resolution? (although I see that
it is done once in the static map now).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
