mcvsubbu commented on a change in pull request #4795: Enhance RoutingTable to
use ServerInstance
URL: https://github.com/apache/incubator-pinot/pull/4795#discussion_r343821880
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryRouter.java
##########
@@ -55,25 +56,27 @@ public QueryRouter(String brokerId, BrokerMetrics
brokerMetrics) {
}
public AsyncQueryResponse submitQuery(long requestId, String rawTableName,
- @Nullable BrokerRequest offlineBrokerRequest, @Nullable Map<String,
List<String>> offlineRoutingTable,
- @Nullable BrokerRequest realtimeBrokerRequest, @Nullable Map<String,
List<String>> realtimeRoutingTable,
+ @Nullable BrokerRequest offlineBrokerRequest, @Nullable
Map<ServerInstance, List<String>> offlineRoutingTable,
+ @Nullable BrokerRequest realtimeBrokerRequest, @Nullable
Map<ServerInstance, List<String>> realtimeRoutingTable,
long timeoutMs) {
assert offlineBrokerRequest != null || realtimeBrokerRequest != null;
// Build map from server to request based on the routing table
Map<Server, InstanceRequest> requestMap = new HashMap<>();
if (offlineBrokerRequest != null) {
assert offlineRoutingTable != null;
- for (Map.Entry<String, List<String>> entry :
offlineRoutingTable.entrySet()) {
- Server server = new Server(entry.getKey(), TableType.OFFLINE);
+ for (Map.Entry<ServerInstance, List<String>> entry :
offlineRoutingTable.entrySet()) {
Review comment:
seq predates me. You approved it :)
```
commit e29933810a701e2e8c4690465ccb8774a0324180
Author: Xiang Fu <[email protected]>
Date: Sun Mar 29 00:36:11 2015 -0700
Bug fixing for federated broker test.
1. fix logic for RealtimeColumnDataSource set range predicate as for
realtime dictionary, dictId is from 1 to dictionary size.
2. in MutableDictionaryReader, getString is also used for other data
type dictionary, so change it to toString().
3. fixing offline ColumnDataSourceImpl would set filteredBitMap to null
in Range query, which actually should be an empty bitMap.
This is the root cause of DummyBlock get called.
4. fixing NPE in HelixExternalViewBasedTimeBoundaryService.
5. fixing time filter attching logic in BrokerRequestHandler for no
filter request.
6. changing attached time filters' ids to -1 and -2 to avoid potiential
duplicated.
RB=453859
R=xiafu
A=kgopalak,jfim
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
