xiangfu0 commented on code in PR #18256:
URL: https://github.com/apache/pinot/pull/18256#discussion_r3260324300
##########
pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java:
##########
@@ -61,9 +62,15 @@ public abstract class BasePeriodicTask implements
PeriodicTask {
}
public BasePeriodicTask(String taskName, long runFrequencyInSeconds, long
initialDelayInSeconds) {
+ this(taskName, runFrequencyInSeconds, initialDelayInSeconds, null);
+ }
+
+ public BasePeriodicTask(String taskName, long runFrequencyInSeconds, long
initialDelayInSeconds,
+ String cronExpression) {
_taskName = taskName;
_intervalInSeconds = runFrequencyInSeconds;
_initialDelayInSeconds = initialDelayInSeconds;
+ _cronExpression = cronExpression;
Review Comment:
add validation that only one should be configured or we will prefer cron
always as it's a nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
