xiangfu0 commented on code in PR #18256:
URL: https://github.com/apache/pinot/pull/18256#discussion_r3315371501
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java:
##########
@@ -57,8 +57,8 @@ public abstract class ControllerPeriodicTask<C> extends
BasePeriodicTask impleme
public ControllerPeriodicTask(String taskName, long runFrequencyInSeconds,
long initialDelayInSeconds,
PinotHelixResourceManager pinotHelixResourceManager,
LeadControllerManager leadControllerManager,
- ControllerMetrics controllerMetrics) {
- super(taskName, runFrequencyInSeconds, initialDelayInSeconds);
+ ControllerMetrics controllerMetrics, String cronExpression) {
Review Comment:
re-order the arguments
```
public ControllerPeriodicTask(String taskName, long runFrequencyInSeconds,
long initialDelayInSeconds, @Nullable String cronExpression,
PinotHelixResourceManager pinotHelixResourceManager, LeadControllerManager
leadControllerManager, ControllerMetrics controllerMetrics) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
