rsrkpatwari1234 commented on PR #18175: URL: https://github.com/apache/pinot/pull/18175#issuecomment-4495522619
> > > > Will this change the emitted metric name? Even for single topic ingestion? > > > > > > > > > Yes. For single-topic tables as well, the underlying metric name string changes, not only for multi-topic. > > > Before: gauges looked like `…realtimeIngestionDelayMs.<tableNameWithType>.<pinotPartitionGroupId>` (table + numeric partition as a separate dot-separated segment). > > > After: the “table” segment is `<tableNameWithType>-<topic>-<streamPartition>` (same pattern as stream consumer metrics), so the full name includes topic and partition in that hyphenated block, and registration uses table gauges (no extra .partition segment the same way as before). > > > > > > This is a big backward incompatible change, which will break all monitoring system right? > > Yes. Could we do --? That way ppl only have to add a ending * It is backward incompatible only for the metrics that used to be keyed as table + Pinot partition and are now keyed like stream consumer metrics: tableNameWithType-topic-streamPartition. Broker/controller/offline metrics, most server gauges, and stream meters that were already on the …-topic-partition… shape are unchanged. Only monitoring that targets those ingestion-delay (and related) series by the old name/labels will break or show gaps until queries are updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
