rseetham commented on code in PR #18175:
URL: https://github.com/apache/pinot/pull/18175#discussion_r3314158397
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -369,27 +379,40 @@ void setClock(Clock clock) {
_clock = clock;
}
+ /** Table key for ingestion gauges for {@code pinotPartitionId}, aligned
with stream consumer metrics. */
+ private String getIngestionGaugeTableKey(int pinotPartitionId) {
+ TableConfig tableConfig =
_realTimeTableDataManager.getCachedTableConfigAndSchema().getLeft();
+ List<StreamConfig> streamConfigs =
IngestionConfigUtils.getStreamConfigs(tableConfig);
+ StreamConfig streamConfig =
IngestionConfigUtils.getStreamConfigFromPinotPartitionId(streamConfigs,
+ pinotPartitionId);
+ int streamPartitionId =
Review Comment:
Since this will stop emitting the current metrics and change their format,
maybe we could emit both the old and new metrics for now and make the old
metrics deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
