xiangfu0 commented on PR #18544: URL: https://github.com/apache/pinot/pull/18544#issuecomment-4525311951
High-signal issue in the source-table validation path: `validateSourceTable(...)` / `resolveSourceTableWithType(...)` still accepts a raw source name when both `foo_OFFLINE` and `foo_REALTIME` exist, because the resolver prefers the OFFLINE table and only rejects the source when OFFLINE is absent. That means `CREATE MATERIALIZED VIEW ... AS SELECT ... FROM foo` can still be persisted for a hybrid source even though the stored `definedSQL` is replayed later against the raw table name. The downstream broker/scheduler query can then read REALTIME rows while validation, fingerprinting, and STALE-marking checks only covered the OFFLINE half. Since realtime commits still do not notify the MV consistency manager, this can silently drift the MV. Please reject raw names that have both OFFLINE and REALTIME variants, or require an explicitly typed source table before persisting the MV. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
