hongkunxu commented on code in PR #18544:
URL: https://github.com/apache/pinot/pull/18544#discussion_r3308183931
##########
pinot-materialized-view/src/test/java/org/apache/pinot/materializedview/metadata/MaterializedViewMetadataTest.java:
##########
@@ -154,4 +155,89 @@ public void testWatermarkAlwaysWritten() {
assertTrue(znRecord.getSimpleFields().containsKey("watermarkMs"),
"watermarkMs key must always be written");
}
+
+ /// Definition equality is the controller's idempotency check at CREATE MV
time: a second
+ /// CREATE with the same definedSQL must hash/compare equal to the first so
a stale orphan
+ /// znode from a prior failed CREATE doesn't get classified as "different
content".
+ /// Verify every persisted field round-trips through equals/hashCode.
+ @Test
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
