pri1712 commented on PR #18256: URL: https://github.com/apache/pinot/pull/18256#issuecomment-4562178891
Resolved comments **Changes made:** 1. Created a new Quartz Scheduler itself for the controller cron scheduler, this was done by creating a new task with the property `PROP_SCHED_INSTANCE_NAME` modified . 2. The quartz scheduler created above also has the number of threads modified in accordance with the number of periodic tasks as well as the number of cores on the machine. The logic is in `PeriodicTaskScheduler.java` 3. Added a regression test which verified that the `PinotTaskManager` scheduler and the `PeriodicTaskScheduler` do not even see each others task namespace and that stopping one of them has no effect/interruptions in the other. The test is titled `testControllerAndMinionCronSchedulerIsolation()` 4. Fixed the ordering of the `cronExpression` in all the periodic task constructors and also made it nullable. 5. Fixed linting issues 6. Rebased against master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
