haibow commented on issue #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#issuecomment-552045427
 
 
   > > I have updated the diff to keep the virtualColumn as is since nothing 
new is introduced here. I will defer the renaming to future diffs where the 
usage of virtualColumn is expanded - hopefully then we can discuss with more 
context.
   > 
   > I was going to suggest this. It is is also easier to review
   
   I have done the change. Mind taking another look?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to