haibow commented on issue #4774: Refactor virtualColumn URL: https://github.com/apache/incubator-pinot/pull/4774#issuecomment-553682978 > I don't think using VirtualColumnContext to pass values are good design in general. VirtualColumnProvider can be plugged in, while VirtualColumnContext is not pluggable. To me, a better design would be putting everything into the VirtualColumnProvider. What's your opinion? I agree VirtualColumnContext was not pluggable enough. Previously all built in virtual columns were included, and now we have a better abstraction by using fieldSpec to support adding virtual columns dynamically. I lean towards keeping each refactoring incremental based on needs. In the future when there are other use cases of virtual columns, more refactoring can be done based on the actual pluggability requirement.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
