Akanksha-kedia commented on code in PR #17584:
URL: https://github.com/apache/pinot/pull/17584#discussion_r3420967205
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BasicAuthTestUtils.java:
##########
@@ -27,14 +27,14 @@ public final class BasicAuthTestUtils {
private BasicAuthTestUtils() {
}
- public static final String AUTH_TOKEN = "Basic YWRtaW46dmVyeXNlY3JldA=====";
+ public static final String AUTH_TOKEN = "Basic YWRtaW46dmVyeXNlY3JldA==";
public static final String AUTH_TOKEN_USER = "Basic dXNlcjpzZWNyZXQ==";
public static final Map<String, String> AUTH_HEADER =
Map.of("Authorization", AUTH_TOKEN);
public static final BasicHeader AUTH_HEADER_BASIC = new
BasicHeader("Authorization", AUTH_TOKEN);
public static final Map<String, String> AUTH_HEADER_USER =
Map.of("Authorization", AUTH_TOKEN_USER);
public static void addControllerConfiguration(Map<String, Object>
properties) {
- properties.put("controller.segment.fetcher.auth.token", AUTH_TOKEN);
+ properties.put("pinot.controller.segment.fetcher.auth.token", AUTH_TOKEN);
Review Comment:
Added a dedicated unit test class AuthProviderUtilsTest in the latest commit
with three cases: (1) correct key pinot.controller.segment.fetcher.auth.token →
auth header present, (2) old wrong key controller.segment.fetcher.auth.token →
no header produced, (3) null config → no header. This makes the regression
directly testable without needing a full integration cluster. @Jackie-Jiang
could you re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
