Akanksha-kedia commented on PR #17584:
URL: https://github.com/apache/pinot/pull/17584#issuecomment-4815881953
@xiangfu0 Fixed two test failures from CI:
1. **`AuthProviderUtilsTest.testCorrectKeyProducesAuthHeader`** (Unit Test
Set 1): `StaticTokenAuthProvider` prefixes the token with `"Basic "`, so
`headers.containsValue("my-secret-token")` was always false. Fixed the
assertion to check the `Authorization` header value contains the raw token as a
substring.
2.
**`BasicAuthBatchIntegrationTest.testControllerSegmentFetcherUsesAuthToken`**
(Integration Test Set 1): `ClassicRequestBuilder.addParameter()` on POST adds
parameters to the form body, not the URL query string. The controller's
`FineGrainedAuthUtils` reads `uriInfo.getQueryParameters()` (URL only), so
`tableName` was not found. Fixed by embedding `?tableName=baseballStats`
directly in the upload URI.
Both fixes pushed — CI should pass now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
