Copilot commented on code in PR #18783:
URL: https://github.com/apache/pinot/pull/18783#discussion_r3424740432
##########
pinot-controller/src/main/resources/app/components/Table.tsx:
##########
@@ -536,14 +559,9 @@ export default function CustomizedTables({
} else if(has(cellData, 'value') && cellData.value) {
return styleCell(cellData.value);
Review Comment:
`makeCell` only treats an object as a `{ value, ... }` cell when
`cellData.value` is truthy. This means valid falsy values (e.g. `0`, `false`,
or an explicit `null`) will fall into the fallback branch and render the whole
object instead of the intended `value` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
