xiangfu0 commented on code in PR #18783:
URL: https://github.com/apache/pinot/pull/18783#discussion_r3424760732
##########
pinot-controller/src/main/resources/app/components/Table.tsx:
##########
@@ -536,14 +559,9 @@ export default function CustomizedTables({
} else if(has(cellData, 'value') && cellData.value) {
return styleCell(cellData.value);
Review Comment:
Good catch — fixed in 99d03c225b. Switched the guard from `has(cellData,
'value') && cellData.value` to a presence check `has(cellData, 'value')`, so
falsy values (`0`, `false`, `null`, `''`) now render via the value path instead
of dumping the whole object. This is safe because `styleCell` now coerces any
type through `toDisplayString`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
