xiangfu0 commented on code in PR #18789:
URL: https://github.com/apache/pinot/pull/18789#discussion_r3431434284
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -204,15 +204,6 @@ public static boolean contains(String canonicalName) {
return FUNCTION_MAP.containsKey(canonicalName);
}
- /**
- * @deprecated For performance concern, use {@link #contains(String)}
instead to avoid invoking
- * {@link #canonicalize(String)} multiple times.
- */
- @Deprecated
- public static boolean containsFunction(String name) {
Review Comment:
Removing the deprecated `containsFunction(String)` /
`getFunctionInfo(String,int)` wrappers is still a binary-incompatible change
for callers compiled against released `pinot-common` jars. Upgraders that still
invoke those entry points will start failing with `NoSuchMethodError`, so Pinot
usually needs to keep the old methods as delegating shims until there is an
explicit compatibility-removal plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
