Akanksha-kedia commented on code in PR #18789:
URL: https://github.com/apache/pinot/pull/18789#discussion_r3435447785
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -204,15 +204,6 @@ public static boolean contains(String canonicalName) {
return FUNCTION_MAP.containsKey(canonicalName);
}
- /**
- * @deprecated For performance concern, use {@link #contains(String)}
instead to avoid invoking
- * {@link #canonicalize(String)} multiple times.
- */
- @Deprecated
- public static boolean containsFunction(String name) {
Review Comment:
Good point, thank you. I'll restore `containsFunction(String)` and
`getFunctionInfo(String,int)` as delegating shims so callers compiled against
released jars don't get `NoSuchMethodError`. The CalciteSqlParser inlining
(private methods only) should remain unaffected — will update this PR shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
