rohityadav1993 commented on code in PR #18760:
URL: https://github.com/apache/pinot/pull/18760#discussion_r3438154754
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/funnel/ThetaSketchAggregationStrategy.java:
##########
@@ -66,8 +75,14 @@ void add(Dictionary dictionary, UpdateSketch[]
stepsSketches, int step, int corr
sketch.update(dictionary.getStringValue(correlationId));
break;
default:
- throw new IllegalStateException("Illegal CORRELATED_BY column data
type for FUNNEL_COUNT aggregation function: "
- + dictionary.getValueType());
+ throw new IllegalStateException(
+ "Illegal CORRELATED_BY column data type for FUNNEL_COUNT
aggregation function: "
+ + dictionary.getValueType());
}
}
+
+ @Override
+ void addMultiKey(UpdateSketch[] stepsSketches, int step, Dictionary[]
dictionaries, int[] correlationDictIds) {
+ stepsSketches[step].update(DictIdsWrapper.toCompositeString(dictionaries,
correlationDictIds));
Review Comment:
I think there will be a lot of new string creation cost and subsequent GC
pressure with `toCompositeString` for each row.
Similarly at other places if cardinality of distinct correlation multi-keys
is high in a query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
