rohityadav1993 commented on code in PR #18760:
URL: https://github.com/apache/pinot/pull/18760#discussion_r3461127651
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/funnel/BitmapAggregationStrategy.java:
##########
@@ -37,8 +37,18 @@ public DictIdsWrapper createAggregationResult(Dictionary
dictionary) {
return new DictIdsWrapper(_numSteps, dictionary);
}
+ @Override
+ public DictIdsWrapper createAggregationResultMultiKey(Dictionary[]
dictionaries) {
+ return new DictIdsWrapper(_numSteps, dictionaries);
+ }
+
@Override
protected void add(Dictionary dictionary, DictIdsWrapper dictIdsWrapper, int
step, int correlationId) {
dictIdsWrapper._stepsBitmaps[step].add(correlationId);
}
+
+ @Override
+ void addMultiKey(DictIdsWrapper dictIdsWrapper, int step, Dictionary[]
dictionaries, int[] correlationDictIds) {
+
dictIdsWrapper._stepsBitmaps[step].add(dictIdsWrapper.getCompositeCorrelationId(correlationDictIds));
Review Comment:
Is it possible to cache/memoize getCompositeCorrelationId, this gets
computed for every step that matches for a multi-key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
