krishan1390 commented on code in PR #18821:
URL: https://github.com/apache/pinot/pull/18821#discussion_r3451300770
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -231,54 +231,54 @@ public String getSegmentMetadata(
Map<String, Map<String, Double>> columnIndexSizesMap = new HashMap<>();
try {
for (SegmentDataManager segmentDataManager : segmentDataManagers) {
- if (segmentDataManager instanceof ImmutableSegmentDataManager) {
- ImmutableSegment immutableSegment = (ImmutableSegment)
segmentDataManager.getSegment();
- long segmentSizeBytes = immutableSegment.getSegmentSizeBytes();
- SegmentMetadataImpl segmentMetadata =
- (SegmentMetadataImpl)
segmentDataManager.getSegment().getSegmentMetadata();
-
- totalSegmentSizeBytes += segmentSizeBytes;
- totalNumRows += segmentMetadata.getTotalDocs();
-
- if (columnSet == null) {
- columnSet = segmentMetadata.getAllColumns();
- } else {
- columnSet.retainAll(segmentMetadata.getAllColumns());
- }
- for (String column : columnSet) {
- ColumnMetadata columnMetadata =
segmentMetadata.getColumnMetadataMap().get(column);
- int columnLength = columnMetadata.getLengthOfLongestElement();
- if (columnLength < 0) {
- // For raw STRING/BYTES/BIG_DECIMAL column, set the columnLength
as the length of the max value.
- Comparable<?> maxValue = columnMetadata.getMaxValue();
- if (maxValue instanceof String) {
- columnLength = Utf8.encodedLength((String) maxValue);
- } else if (maxValue instanceof ByteArray) {
- columnLength = ((ByteArray) maxValue).length();
- } else if (maxValue instanceof BigDecimal) {
- columnLength = BigDecimalUtils.byteSize((BigDecimal) maxValue);
- } else {
- // For type of STRUCT, MAP, LIST, set the columnLength as
DEFAULT_MAX_LENGTH (512).
- columnLength = FieldSpec.DEFAULT_MAX_LENGTH;
- }
- }
- int columnCardinality = columnMetadata.getCardinality();
- columnLengthMap.merge(column, (double) columnLength, Double::sum);
- columnCardinalityMap.merge(column, (double) columnCardinality,
Double::sum);
- if (!columnMetadata.isSingleValue()) {
- int maxNumMultiValues =
columnMetadata.getMaxNumberOfMultiValues();
- maxNumMultiValuesMap.merge(column, (double) maxNumMultiValues,
Double::sum);
+ for (IndexSegment indexSegment :
segmentDataManager.getReportableSegments()) {
Review Comment:
this is an indentation change due to looping over
segmentDataManager.getReportableSegments()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
