krishan1390 commented on code in PR #18821:
URL: https://github.com/apache/pinot/pull/18821#discussion_r3472054212
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/SegmentDataManager.java:
##########
@@ -82,6 +90,18 @@ public List<IndexSegment> getSegments() {
return Collections.emptyList();
}
+ /**
+ * The index segment(s) this manager exposes.
+ * Defaults to the single backing segment.
+ */
+ public List<IndexSegment> getReportableSegments() {
+ return List.of(getSegment());
+ }
Review Comment:
All observability changes are replacements of getSegment() with
getReportableSegments() . So there is no change in behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
