J-HowHuang commented on code in PR #18834:
URL: https://github.com/apache/pinot/pull/18834#discussion_r3455990853
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/geospatial/OffHeapH3IndexCreator.java:
##########
@@ -83,6 +83,11 @@ public void add(@Nullable Geometry geometry)
*/
private void flush()
throws IOException {
+ // Skip flushing an empty posting list map. This could happen when add()
didn't add any entry due to invalid
+ // Geometry and _continueOnError is set
+ if (_postingListMap.isEmpty()) {
Review Comment:
done. also changed the other caller (line 118)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
