Jackie-Jiang commented on code in PR #18834:
URL: https://github.com/apache/pinot/pull/18834#discussion_r3456189822
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/geospatial/OffHeapH3IndexCreator.java:
##########
@@ -113,7 +115,7 @@ public void seal()
}
// Flush the last chunk
- if (_postingListMap.size() % FLUSH_THRESHOLD != 0) {
+ if (!_postingListMap.isEmpty() && _postingListMap.size() % FLUSH_THRESHOLD
!= 0) {
Review Comment:
(minor) This is actually redundant. Actually it might be more clear to only
check whether map is empty
```suggestion
if (!_postingListMap.isEmpty()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
