Jackie-Jiang commented on code in PR #18820:
URL: https://github.com/apache/pinot/pull/18820#discussion_r3461816461
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -632,6 +632,15 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
// Validate the request
try {
validateRequest(serverPinotQuery, _queryResponseLimit);
+ // For gapfill queries, validate that all TIMESERIESON columns are
present in the SELECT list
+ // before incurring a server round-trip.
+ if (pinotQuery != serverPinotQuery) {
+ QueryContext outerQueryContext =
QueryContextConverterUtils.getQueryContext(pinotQuery);
Review Comment:
This extra query compilation could be expensive. To avoid the overhead, is
it possible to combine the validation into `GapfillUtils.stripGapfill()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
