Akanksha-kedia commented on code in PR #18820:
URL: https://github.com/apache/pinot/pull/18820#discussion_r3467353019
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -632,6 +632,15 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
// Validate the request
try {
validateRequest(serverPinotQuery, _queryResponseLimit);
+ // For gapfill queries, validate that all TIMESERIESON columns are
present in the SELECT list
+ // before incurring a server round-trip.
+ if (pinotQuery != serverPinotQuery) {
+ QueryContext outerQueryContext =
QueryContextConverterUtils.getQueryContext(pinotQuery);
Review Comment:
Done! Moved the validation into `GapfillUtils.stripGapfill(PinotQuery)`. It
now works directly on the Thrift `PinotQuery`/`Expression` objects already in
scope — no extra `getQueryContext()` compilation needed. The
`QueryContext`-based `validateGapfillColumns` method has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
