tarun11Mavani commented on code in PR #18760:
URL: https://github.com/apache/pinot/pull/18760#discussion_r3466360752
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/funnel/AggregationStrategy.java:
##########
@@ -52,13 +56,38 @@ public AggregationStrategy(List<ExpressionContext>
stepExpressions, List<Express
_correlateByExpressions = correlateByExpressions;
_primaryCorrelationCol = _correlateByExpressions.get(0);
_numSteps = _stepExpressions.size();
+ _numCorrelateByKeys = _correlateByExpressions.size();
}
/**
- * Returns an aggregation result for this aggregation strategy to be kept in
a result holder (aggregation only).
+ * Creates an aggregation result for single-key correlation.
*/
abstract A createAggregationResult(Dictionary dictionary);
+ /**
+ * Creates an aggregation result for multi-key correlation.
+ */
+ abstract A createAggregationResultMultiKey(Dictionary[] dictionaries);
Review Comment:
make sense. We'll keep the physical column restriction for this PR and
follow up with expression support for secondary keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
