tarun11Mavani commented on code in PR #18643:
URL: https://github.com/apache/pinot/pull/18643#discussion_r3503450432
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -135,6 +147,34 @@ public void indexColumn(String columnName, @Nullable int[]
sortedDocIds, IndexSe
}
Review Comment:
Agreed — a shared `CompositeDataSource` interface would be cleaner than
per-type `instanceof` forks. I'd prefer to tackle it as a follow-up after the
OPEN_STRUCT stack lands, since it would also touch the MAP code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
