anuragrai16 commented on code in PR #18914:
URL: https://github.com/apache/pinot/pull/18914#discussion_r3517954263
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1495,10 +1495,14 @@ SegmentCompletionProtocol.Response
postSegmentStoppedConsuming() {
// Inform the controller that the server had to stop consuming due to an
error.
protected void postStopConsumedMsg(String reason) {
- ConsumptionStopIndicator indicator = new
ConsumptionStopIndicator(_currentOffset,
Review Comment:
We've moved `ConsumptionStopIndicator` in the loop, is that needed or can we
reuse it across retries ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
