goutamadwant commented on PR #18914: URL: https://github.com/apache/pinot/pull/18914#issuecomment-4879516318
@anuragrai16I addressed the comments by reusing the `ConsumptionStopIndicator` across retries, switching the registered-manager check to `getSegmentDataManager`, adding the null guard and Javadoc, and adding the comment explaining why the ERROR -> OFFLINE cleanup path logs without rethrowing. I also updated the tests to cover the non-refcounting lookup path. Let me know if you have any further suggestions. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
