shauryachats commented on code in PR #18608:
URL: https://github.com/apache/pinot/pull/18608#discussion_r3522794520
##########
pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java:
##########
@@ -163,6 +166,24 @@ void initializeZK() {
void initializeMetricsReporter() {
LOGGER.info("Initializing metrics reporter");
+ try {
+ ServerConf serverConf = new ServerConf(_pinotConfig);
Review Comment:
nit: Is it possible to separate this and the existing server metrics init
logic out into a common method and reuse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
