goutamadwant commented on code in PR #18914:
URL: https://github.com/apache/pinot/pull/18914#discussion_r3532838430
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1539,7 +1499,13 @@ protected void postStopConsumedMsg(String reason) {
ConsumptionStopIndicator indicator = new
ConsumptionStopIndicator(_currentOffset,
_segmentNameStr, _instanceId, _protocolHandler, reason,
_segmentLogger);
do {
- SegmentCompletionProtocol.Response response =
indicator.postSegmentStoppedConsuming();
+ if (hasDifferentSegmentDataManagerRegistered()) {
+ _segmentLogger.info(
+ "Skip segmentStoppedConsuming for segment: {}, another segment
data manager is already registered",
+ _segmentNameStr);
+ return;
+ }
Review Comment:
Done @noob-se7en
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
