goutamadwant commented on code in PR #18914:
URL: https://github.com/apache/pinot/pull/18914#discussion_r3532841162
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -236,6 +236,15 @@ public void onBecomeDroppedFromOnline(Message message,
NotificationContext conte
@Transition(from = "ERROR", to = "OFFLINE")
public void onBecomeOfflineFromError(Message message, NotificationContext
context) {
_logger.info("SegmentOnlineOfflineStateModel.onBecomeOfflineFromError()
: {}", message);
+ try {
+ _instanceDataManager.offloadSegment(message.getResourceName(),
message.getPartitionName());
Review Comment:
Agreed. I removed the ERROR -> OFFLINE offload change and its test from this
PR. This PR now only covers the stale initialization-error notification
mitigation. The ERROR -> OFFLINE cleanup can be handled separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
