Akanksha-kedia commented on code in PR #17072:
URL: https://github.com/apache/pinot/pull/17072#discussion_r3535394585
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -76,9 +75,8 @@ public class TableConfigBuilder {
@Deprecated
private String _segmentPushFrequency;
- // TODO: Remove 'DEFAULT_SEGMENT_PUSH_TYPE' in the future major release.
@Deprecated
- private String _segmentPushType = DEFAULT_SEGMENT_PUSH_TYPE;
Review Comment:
Keeping `_segmentPushType`, `_segmentPushFrequency`, and their public
getters/setters for now — removing public API in a minor version would fail the
binary compatibility check (`METHOD_REMOVED` on `pinot-spi`).
The branch has been rebased cleanly to just remove the **private** constants
`DEFAULT_SEGMENT_PUSH_TYPE` and `REFRESH_SEGMENT_PUSH_TYPE`, which were only
used within `TableConfigBuilder` itself. The string literals are inlined in the
deprecated `setSegmentPushType()` method body. Method removal can follow in the
next major release.
##########
.github/workflows/japicmp-exclude.xml:
##########
@@ -16,18 +14,11 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-#
-
-set -e
-
-MANIFEST_TAG="apachepinot/pinot-base-${BASE_IMAGE_TYPE}:${TAG}"
-
-# Remove any existing local manifest so re-runs of a failed workflow don't fail
-# with "manifest already exists".
-docker manifest rm "${MANIFEST_TAG}" 2>/dev/null || true
-
-docker manifest create "${MANIFEST_TAG}" \
- --amend "apachepinot/pinot-base-${BASE_IMAGE_TYPE}:${TAG}-amd64" \
- --amend "apachepinot/pinot-base-${BASE_IMAGE_TYPE}:${TAG}-arm64"
-docker manifest push "${MANIFEST_TAG}"
+# Deprecated methods intentionally removed in this release
Review Comment:
Agreed and done — the `japicmp-exclude.xml` file has been removed. The
branch has been rebased from scratch; the only change is inlining the two
private string constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
