Jackie-Jiang commented on code in PR #18751:
URL: https://github.com/apache/pinot/pull/18751#discussion_r3553522456
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -817,7 +818,7 @@ protected void startKafkaWithoutTopic() {
EmbeddedKafkaCluster cluster = new EmbeddedKafkaCluster();
cluster.init(props);
cluster.start();
- _kafkaStarters = List.of(cluster);
+ _kafkaStarters = Collections.singletonList(cluster);
Review Comment:
(minor) Don't change this. Prefer `List.of()` over
Collections.singletonList()`
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/h3/H3IndexType.java:
##########
@@ -84,6 +83,20 @@ public void validate(FieldIndexConfigs indexConfigs,
FieldSpec fieldSpec, TableC
column);
Preconditions.checkState(fieldSpec.getDataType().getStoredType() ==
DataType.BYTES,
"Cannot create H3 index on column: %s of stored type other than
BYTES", column);
+ for (IndexType<?, ?, ?> indexType : List.of(
+ StandardIndexes.bloomFilter(),
+ StandardIndexes.dictionary(),
+ StandardIndexes.inverted(),
+ StandardIndexes.vector(),
+ StandardIndexes.range(),
+ StandardIndexes.json(),
+ StandardIndexes.text(),
+ StandardIndexes.fst(),
+ StandardIndexes.ifst())) {
+
Preconditions.checkState(indexConfigs.getConfig(indexType).isDisabled(),
Review Comment:
Why is this? H3 index shouldn't conflict with other indexes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
