RajaVinoth96 commented on code in PR #18751:
URL: https://github.com/apache/pinot/pull/18751#discussion_r3555700074
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/h3/H3IndexType.java:
##########
@@ -84,6 +83,20 @@ public void validate(FieldIndexConfigs indexConfigs,
FieldSpec fieldSpec, TableC
column);
Preconditions.checkState(fieldSpec.getDataType().getStoredType() ==
DataType.BYTES,
"Cannot create H3 index on column: %s of stored type other than
BYTES", column);
+ for (IndexType<?, ?, ?> indexType : List.of(
+ StandardIndexes.bloomFilter(),
+ StandardIndexes.dictionary(),
+ StandardIndexes.inverted(),
+ StandardIndexes.vector(),
+ StandardIndexes.range(),
+ StandardIndexes.json(),
+ StandardIndexes.text(),
+ StandardIndexes.fst(),
+ StandardIndexes.ifst())) {
+
Preconditions.checkState(indexConfigs.getConfig(indexType).isDisabled(),
Review Comment:
My understanding was that if H3 is enabled on another column , it is
pointless to have other index types enabled on the same column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
