Akanksha-kedia opened a new pull request, #18957: URL: https://github.com/apache/pinot/pull/18957
## Summary `VectorIndexConfig` was the only index config class in the SPI that did not implement `equals()` and `hashCode()`. Every other config class (`BloomFilterConfig`, `TextIndexConfig`, `JsonIndexConfig`, `H3IndexConfig`) has these methods. Without them, two configs with identical fields compare unequal by object identity, which breaks: - `Map`/`Set` lookups keyed by config - Config-change detection that compares stored vs. desired config - Any equality assertion in tests - Adds `equals()` and `hashCode()` to `VectorIndexConfig` following the same pattern as `BloomFilterConfig` - Adds `VectorIndexConfigTest` with 9 cases: same instance, identical configs, different dimension, different distance function, different backend, different properties, disabled vs. enabled, null comparison, and hash code consistency ## Test plan - [ ] `VectorIndexConfigTest` — 9 unit tests covering equals/hashCode contract - [ ] `./mvnw checkstyle:check -pl pinot-segment-spi` passes (0 violations) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
