tarun11Mavani commented on code in PR #19040:
URL: https://github.com/apache/pinot/pull/19040#discussion_r3664377271
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/openstruct/MutableOpenStructDataSource.java:
##########
@@ -62,10 +63,13 @@ public ComplexFieldSpec getFieldSpec() {
@Override
@Nullable
public DataSource getDataSource(String key) {
- Map<IndexType, IndexReader> indexes = _index.getIndexes(key);
- if (indexes == null || indexes.isEmpty()) {
+ MutableKeyColumn col = _index.getKeyColumn(key);
+ if (col == null) {
return null;
}
+ Map<IndexType, IndexReader> indexes = new
HashMap<>(_index.getIndexes(key));
+ indexes.put(StandardIndexes.nullValueVector(),
+ new PresenceBasedNullValueVector(col.getPresenceBitmap(), _numDocs));
Review Comment:
Good catch on the asymmetry. the two sides do get null info by different
mechanisms — but the
sealed side is covered. `OpenStructColumnSplitter:326-336` runs a
`NullValueVectorCreator` for every
materialized child column at seal time, so dense keys get a real on-disk
null vector and the
`nullReader == null` branch isn't reached.
No existing test has a partially-present dense key. I plan to add a
dedicated pr with integration tests. I will cover this case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
