J-HowHuang commented on PR #18920: URL: https://github.com/apache/pinot/pull/18920#issuecomment-5110237660
I feel like our current approach to patch `needUpdateIndices` in different indexes is not consistent. We have three different places to persist the ground truth config used to create the current index: https://github.com/apache/pinot/pull/18920: Json index, persist in `metadata.properties` as a serialized `JsonIndexConfig` https://github.com/apache/pinot/pull/19046: Vector index, persist as an individual file as a metadata key-value map https://github.com/apache/pinot/pull/18898: Bloom filter, persist in the index's header in `column.psf` Can I request to have an uniform solution to compare the configs used to construct a segment with the current table config? This way we can save a lot of effort in the future maintaining the code. cc @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
